Please enable JavaScript.

Coggle requires JavaScript to display documents.

Teamcity incident (RCA (What .teamcity changes happened in Analytics…

- - - - Build got succeeded for this commit
        
        This commit changed vcsRoots
        
        It modified branchSpec
        
        removed +:refs/(pull-requests/*)/from in branch spec
        
        Added +:refs/heads/(feature//) and many more
    - - This commit reverts 208a
- - - - Branch spec update changing branch names, triggers builds in every branch which has commits
        
        How to reproduce?
        
        create build config with git VCS root & branchSpec '+:refs/heads/*'
        
        add a VCS trigger to this build config
        
        create several branches with commits, make TC run builds in these branches
        
        change branch spec to '+:refs/*'
        
        This triggers new builds & it's overview tab shows branches starting with 'heads/'
        
        All of them have pending changes
        
        Why it happens?
        
        To calculate changes we traverse commit graph upto previous build in same / default branch
        
        there were no builds in branches starting with 'heads/' before
        
        VCS trigger treats these branches as newly pushed & since they have pending changes it runs a build in every renamed branch
        
        If branch spec is changed in VCS root, then VCS trigger will trigger new builds with new logical branch names (if there were pending changes)
        
        even though there were no new changes in these branches
        
        coz trigger stores in it's state, the id of the change which caused triggering in a logical branch previously
        
        but if logical branch name changes, this info is lost & trigger thinks this is a new branch with new pending change & triggers build again
        
        Is if fixed?
        
        we tried to fix that previously by skipping changes collected in new branches discovered after branch spec update
        
        but it's not enough & VCS trigger should also handle branch spec updates
        
        partially addressed in 2018.2.1
        
        if builds were triggered in branches & no new changes were detected in these branches & branch spec was changed
        
        then we shouldn't trigger builds in new logical branches anymore